Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDISCROWD-4966 Fix for assigned users empty #766

Merged
merged 10 commits into from
Aug 23, 2022
Merged

RDISCROWD-4966 Fix for assigned users empty #766

merged 10 commits into from
Aug 23, 2022

Conversation

kbecker42
Copy link

@kbecker42 kbecker42 commented Aug 19, 2022 •
edited
Loading

  • Added fix for removing all assigned users from a task to allow it to become available to workers again (not empty [] value).
  • Added fix for bulk get assign users.

@kbecker42 kbecker42 requested a review from XiChenn August 19, 2022 14:19
@coveralls
Copy link

coveralls commented Aug 19, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2912551719

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 94.798%
Totals Coverage Status
Change from base Build 2889706491: 0.1%
Covered Lines: 16219
Relevant Lines: 17109
💛 - Coveralls

XiChenn
XiChenn reviewed Aug 19, 2022
View reviewed changes
pybossa/view/projects.py
user_pref["assign_user"] = assign_user
if assign_user:
user_pref["assign_user"] = assign_user
elif "assign_user" in user_pref:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this delete key logic covered in the unit test?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests added, thank you. :)

@kbecker42 kbecker42 added the bug label Aug 22, 2022
@kbecker42 kbecker42 requested a review from XiChenn August 22, 2022 19:59
@kbecker42 kbecker42 merged commit c04a65a into main Aug 23, 2022
This was referenced Aug 24, 2022
Merged
Merged
XiChenn
XiChenn reviewed Aug 25, 2022
View reviewed changes
Copy link

@XiChenn XiChenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiChenn XiChenn XiChenn left review comments

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
3 participants
@kbecker42 @coveralls @XiChenn