Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDISCROWD-4966 Fix for assigned users empty #766

Merged
merged 10 commits into from
Aug 23, 2022
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pybossa/view/projects.py
Original file line number Diff line number Diff line change
Expand Up @@ -1873,7 +1873,10 @@ def bulk_update_assign_worker(short_name):
if remove_user_email in assign_user:
assign_user.remove(remove_user_email)

user_pref["assign_user"] = assign_user
if assign_user:
user_pref["assign_user"] = assign_user
elif "assign_user" in user_pref:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this delete key logic covered in the unit test?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests added, thank you. :)

del user_pref["assign_user"]

t.user_pref = user_pref
flag_modified(t, "user_pref")
Expand Down