RDISCROWD-5484 Fix for sort on browse tasks #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbecker42
commented
Oct 10, 2022
kbecker42
commented
- Bug fix for sorting on browse tasks.
kbecker42
changed the title
kbecker42
commented
Oct 10, 2022
pybossa/cache/projects.py
Outdated
| @@ -252,7 +252,7 @@ def search_lock_status_sorting_result(): | |||
| # if not sort by lock_status or locked_tasks_in_project is empty/None, | |||
| # sort by the column "order_by" | |||
| order_by = args.get('order_by') | |||
| sql_order_by = 'id ASC' if not (locked_tasks_in_project and order_by) else order_by | |||
| sql_order_by = order_by if not locked_tasks_in_project and order_by else 'id ASC' | |||
There was a problem hiding this comment.
The sort will not function if locked_tasks_in_project is TRUE. Perhaps, this line should be changed to:
sql_order_by = order_by or 'id ASC'
Pull Request Test Coverage Report for Build 3220996668
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.