Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDISCROWD-5484 Fix for sort on browse tasks #785

Merged
merged 3 commits into from
Oct 10, 2022
Merged

RDISCROWD-5484 Fix for sort on browse tasks #785

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ddb2e2
Fix for sort on browse tasks
kbecker42 Oct 10, 2022
eb26c1d
fix
kbecker42 Oct 10, 2022
cf03010
touch
kbecker42 Oct 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pybossa/cache/projects.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ def search_lock_status_sorting_result():
# if not sort by lock_status or locked_tasks_in_project is empty/None,
# sort by the column "order_by"
order_by = args.get('order_by')
sql_order_by = 'id ASC' if not (locked_tasks_in_project and order_by) else order_by
sql_order_by = order_by if not locked_tasks_in_project and order_by else 'id ASC'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sort will not function if locked_tasks_in_project is TRUE. Perhaps, this line should be changed to:

sql_order_by = order_by or 'id ASC'

sql_query = sql + sql_order.format(sql_order_by) + sql_limit_offset

results = session.execute(text(sql_query), params)
Expand Down