Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDISCROWD-5775 limit task expiration #830

Merged
merged 3 commits into from
Mar 28, 2023

Conversation

n00rsy
Copy link

@n00rsy n00rsy commented Mar 20, 2023

Issue number of the reported bug or feature request: RDISCROWD-5775

Describe your changes
Modifies the task API so that task expiration cannot be set beyond the permitted max expiration (60 days for private and 180 days for public) using a PUT request.
If the user tries to set task expiration beyond the limit, it is set to the maximum possible expiration and the method returns a 200 response code.

Testing performed
Tested Locally

@coveralls
Copy link

coveralls commented Mar 20, 2023

Pull Request Test Coverage Report for Build 4473521466

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0007%) to 94.071%

Totals Coverage Status
Change from base Build 4439432491: 0.0007%
Covered Lines: 16738
Relevant Lines: 17793

💛 - Coveralls

@n00rsy n00rsy requested a review from ciaracian March 24, 2023 14:40
Copy link

@ciaracian ciaracian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks Noor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants