RDISCROWD-5852 Calc task expiration by create date

[n00rsy]

Issue number of the reported bug or feature request: RDISCROWD-5852

Describe your changes

Previously
In #830, we limited the task expiration based on the current date. The task expiration limit was n days from the current day. This allowed for the user to indefinitely extend their tasks' expirations, which we don't want.
Now
Task expiration limit is now n days from the create date of the task, putting a hard cap on task expiration.

Testing performed
Tested locally

Additional context
#830

[coveralls]

Pull Request Test Coverage Report for Build 4734536223

• 24 of 24 (100.0%) changed or added relevant lines in 5 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.002%) to 94.111%

---

Totals
Change from base Build 4564950531:	0.002%
Covered Lines:	16860
Relevant Lines:	17915

---

💛 - Coveralls

[dchhabda]

If user sets expiration beyond max expiration from task create date, will api report 403 along with appropriate message such as Task expiration cannot be set beyond max expiration or it silently sets max expiration from create date and no error reported? If its later, I think NOOP and reporting 403 and appropriate error would be more useful.

[n00rsy]

If user sets expiration beyond max expiration from task create date, will api report 403 along with appropriate message such as Task expiration cannot be set beyond max expiration or it silently sets max expiration from create date and no error reported? If its later, I think NOOP and reporting 403 and appropriate error would be more useful.

Should we implement similar error reporting behavior for importing tasks? the same get_task_expiration function is used in importing and the task api. See: https://github.com/bloomberg/pybossa/blob/main/pybossa/importers/importer.py#L211

[dchhabda]

Should we implement similar error reporting behavior for importing tasks? the same get_task_expiration function is used in importing and the task api.

Yes, as this error would occur with task create_date null/empty (which is invalid) and system should not have tasks created without setting create date. In case of import, code flow need to ensure that error is handled so that all possible tasks gets imported.

[dchhabda]

I think setting gold task should not be setting task expiration as both operations are independent and hence task expiration not to be modified with setting gold task.

@kbecker42 , @XiChenn , @n00rsy thoughts?

[XiChenn]

lgtm