forked from Scifabric/pybossa
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RDISCROWD 5743 task browse bookmarks #832
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4555766290
💛 - Coveralls |
dchhabda
reviewed
Mar 27, 2023
XiChenn
reviewed
Mar 28, 2023
remove print statement
b4b0109
to
90aa8bb
Compare
dchhabda
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. can be merged upon tests/coverage pass. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: RDISCROWD-5743
Describe your changes
Add new API methods:
GET /<user_name>/taskbrowse_bookmarks/<short_name>
: get a list of the user's bookmarks for the specified user and project.Response JSON:
{ name1: url1, name2: url2...}
POST /<user_name>/taskbrowse_bookmarks/<short_name>
: add a new bookmark for the specified user and project.Request JSON:
{name: <new bookmark name>, url: <new bookmark url>}
Response JSON: new list of bookmarks
{ name1: url1, name2: url2...}
DELETE /<user_name>/taskbrowse_bookmarks/<short_name>
: delete the specified bookmark by nameRequest JSON:
{name: <bookmark to delete>}
Response JSON: new list of bookmarks
{ name1: url1, name2: url2...}
Bookmarks are stored in user data (in postgres db) in the following format:
Testing performed
Tested locally