Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rdiscrowd 5851 taskbrowse bookmarks dates #837

Merged
merged 16 commits into from
Apr 26, 2023

Conversation

n00rsy
Copy link

@n00rsy n00rsy commented Apr 10, 2023

Issue number of the reported bug or feature request: RDISCROWD-5851

Describe your changes
Adds created and updated fields for each bookmark. New data structure in DB:

user.info = { 
             metadata...,
             taskbrowse_bookmarks : {
	                            project_name : {
			                         bookmark_name : {
                                                                   url: http://localhost:5000/project/proj/...
                                                                   created: 2023-04-05T17:59:28.516927
                                                                   updated: 2023-04-05T17:59:28.516927
			                         }
                                                 ....
		                    },
	                            project_name : {
			                         bookmark_name : {...,
                                                 bookmark_name : {...,
                                                 bookmark_name : {...
                                                 ....
		                    }
                                    ...
                  }
}

Example endpoint JSON response structure:

[
   {
      "created": "2023-04-26T18:17:29.745312",
      "name": "apple",
      "updated": "2023-04-26T18:17:29.745320",
      "url": "http://localhost:5000/project/testproject2/tasks/browse"
   },
{
      "created": "2023-04-06T18:17:29.745312",
      "name": "banana",
      "updated": "2023-04-06T18:17:29.745320",
      "url": "http://localhost:5000/project/testproject2/tasks/browse"
   },
]

Testing performed
Tested locally

Additional context

@coveralls
Copy link

coveralls commented Apr 10, 2023

Pull Request Test Coverage Report for Build 4812350298

  • 26 of 26 (100.0%) changed or added relevant lines in 1 file are covered.
  • 30 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.01%) to 94.122%

Files with Coverage Reduction New Missed Lines %
pybossa/api/init.py 1 97.53%
pybossa/task_creator_helper.py 1 98.15%
pybossa/api/task.py 5 93.62%
pybossa/importers/importer.py 6 97.01%
pybossa/repositories/task_repository.py 17 92.08%
Totals Coverage Status
Change from base Build 4564950531: 0.01%
Covered Lines: 16909
Relevant Lines: 17965

💛 - Coveralls

@n00rsy n00rsy force-pushed the RDISCROWD-5851-taskbrowse-bookmarks-dates branch 2 times, most recently from cdc76e9 to 30dd46c Compare April 10, 2023 21:45
@n00rsy n00rsy requested a review from dchhabda April 25, 2023 15:23
pybossa/view/account.py Outdated Show resolved Hide resolved
pybossa/view/account.py Outdated Show resolved Hide resolved
pybossa/view/account.py Show resolved Hide resolved
Copy link

@dchhabda dchhabda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants