Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a landing page for the documentation #110

Merged
merged 3 commits into from
Jul 4, 2023
Merged

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Jun 30, 2023

To make thinks shiny and cool, add a landing page instead of using the
Sphinx index page.

@godlygeek
Copy link
Contributor

Mm. We changed the GitHub Actions to not run the tests if nothing in src/ changed, which seemed clever at the time and like a way to save time - but of course, no our required status checks aren't reported 😓

@godlygeek
Copy link
Contributor

I've iterated on this a bit. I force pushed my changes, and the version with my changes can be previewed at https://godlygeek.github.io/pystack/

@sarahmonod
Copy link
Contributor

sarahmonod commented Jun 30, 2023

About docs/_static/images/native.png, doesn't PyStack normally have different colors for C vs Python?

I'm also not a big fan of the red squiggles under some of the words, probably a quirk of the way the screenshots were made in the first place.

@godlygeek
Copy link
Contributor

About docs/_static/images/native.png, doesn't PyStack normally have different colors for C vs Python?

Hm, yes...

I'm also not a big fan of the red squiggles under some of the words

Also yes...

@pablogsal Would you like to take another swing at these? Or I can do it, but then we'll wind up with PuTTY instead of - iTerm2, I guess? We'll have Windows title bars instead of Mac ones, at least (or crop the title bars out 🤷)

@pablogsal
Copy link
Member Author

About docs/_static/images/native.png, doesn't PyStack normally have different colors for C vs Python?

Hm, yes...

I'm also not a big fan of the red squiggles under some of the words

Also yes...

@pablogsal Would you like to take another swing at these? Or I can do it, but then we'll wind up with PuTTY instead of - iTerm2, I guess? We'll have Windows title bars instead of Mac ones, at least (or crop the title bars out 🤷)

Is not iterm, is https://carbon.sh. I can give it a go this night but if you want to replace them, just generate images with transparent backgrounds there

Copy link

@gmc444-b gmc444-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions.

Should one of the blurb mention that you'll also get stack traces for threads not owned by the interpreter?

There's also this article that may be worthy of inclusion in the media section.

https://www.prweb.com/releases/bloomberg_wins_superuser_award_in_recognition_of_outstanding_use_support_of_open_infrastructure/prweb19385294.htm

docs/_templates/index.html Outdated Show resolved Hide resolved
docs/_templates/index.html Outdated Show resolved Hide resolved
docs/_templates/index.html Outdated Show resolved Hide resolved
@pablogsal
Copy link
Member Author

There's also this article that may be worthy of inclusion in the media section.

prweb.com/releases/bloomberg_wins_superuser_award_in_recognition_of_outstanding_use_support_of_open_infrastructure/prweb19385294.htm

Hummm, but this article does not speak itself about pystack directly no? Is more about BB in general more than focusing on the tool

To make thinks shiny and cool, add a landing page instead of using the
Sphinx index page.

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
@pablogsal
Copy link
Member Author

@pablogsal Would you like to take another swing at these? Or I can do it, but then we'll wind up with PuTTY instead of - iTerm2, I guess? We'll have Windows title bars instead of Mac ones, at least (or crop the title bars out 🤷)

Fixed

This was preenting us to get the required checks in PRs only when docs
are updated.

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
@pablogsal pablogsal force-pushed the pages branch 8 times, most recently from 2c48616 to 000ff46 Compare July 4, 2023 14:38
In the latest iteration of the arch Linux container, we need to also
deactivate seccomp to be able to run `gcore` and `ptrace` in the
container.

In addition to that, seems that the new libc is too optimized and some
of our tests are too strict over the number of native frames that must
be present in pthread-based threads, so we need to be a bit more
permissive.

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
@pablogsal pablogsal merged commit e579fb9 into bloomberg:main Jul 4, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants