fix: Don't break at calculating log of numbers close to zero #103
Conversation
|
@pablogsal I know my math teacher wouldn't be very proud of this PR, but I'd love your feedback anyway |
|
Thanks for the PR @gnufede! I’m currently on vacation but I’m sure @godlygeek can take a look soon :) |
If the program performs zero byte allocations, pretend that they were one byte allocations instead. This way they'll be counted in the lowest histogram bucket, as they should be, but we won't attempt to call `math.log(0)` and get a math domain error. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
|
Thanks for the bug report. I've gone with a different fix, though. This case would only come up when the program performed an allocation of zero bytes. If we hadn't been causing an exception by calling Instead, I've updated this PR to just pretend that zero-byte allocations were one-byte allocations, so that they still get counted in the histogram, and just get slotted into the smallest bin. @pablogsal Mind giving me a review here, since I've rewritten this PR? |
Issue number of the reported bug or feature request: #102
Describe your changes
Manage the case when calculating log of numbers too close to zero.
Testing performed
None yet.