Improve tests #112
Merged
Improve tests #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure if these ever worked, but at least with current versions of tox you definitely need to provide a wildcard in order for them to be passed along. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
We were already doing this explicitly in CI, but this commit updates us to run the coverage tests with 3.12 instead of 3.11, and to test 3.12 by default when tox is run from the command line. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
When this test was selected to be run with `pytest -k` or `--lf`, it
would fail because of allocations made by the platform threading
implementation:
- 8.0MiB allocated here:
__pthread_create_2_1
PyThread_start_new_thread
...
When it was run as part of the larger test suite, it would pass, because
the test suite had already started other threads, and paid that cost in
a place where we weren't looking for leaks.
Since we can't tell pthreads not to cache the pthread_t for later reuse,
the best we can do here is just raise all of our thresholds for this
test by a constant factor, so that the ones that are supposed to fail
will fail with or without an extra 8 MB allocation, and the ones that
are supposed to pass will pass with or without it as well.
This commit scales all of the sizes and limits used by this test up by
a factor of 4096 (and drops one of the test vectors, since we don't need
to leak 400 MB just to prove a point when we already know we fail after
leaking 40 MB).
Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
godlygeek
force-pushed
the
fix_test_isolation
branch
from
ed8dea5
to
14838d8
Compare
pablogsal
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few different issues that I noticed while working on #103:
PYTEST_ADDOPTSenvironment variable wasn't being passed through to pytest by tox, apparently due to our config file not using a wildcard where we meant to.