Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --most-allocations with the value of 0 #94

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Sep 25, 2023

In the docs we say that a value of 0 will show all entries but
currently the plugin crashes because it interprets the value of 0 as a
string and is not properly propagated to show all entries.

*Issue number of the reported bug or feature request: #46

Describe your changes
A clear and concise description of the changes you have made.

Testing performed
Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned.

Additional context
Add any other context about your contribution here.

In the docs we say that a value of 0 will show all entries but
currently the plugin crashes because it interprets the value of 0 as a
string and is not properly propagated to show all entries.
@godlygeek
Copy link
Contributor

CI failed because our lint checks are broken on main.

#95 will fix that, and then this will need to be rebased once that lands.

@godlygeek
Copy link
Contributor

Actually, I'll just land this despite the failing lint check. No reason to hold this one up given that CI for main is already failing, and I've tested locally that rebasing on #95 would make linting pass.

Copy link
Contributor

@godlygeek godlygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godlygeek godlygeek merged commit 8c263ec into bloomberg:main Sep 25, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants