Address review comments

Signed-off-by: Gus Monod <gmonod1@bloomberg.net>
bloomberg · Oct 21, 2023 · 06dbc47 · 06dbc47
1 parent 829f9b2
commit 06dbc47
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -3,8 +3,6 @@ name: Tests
 on:
   push:
   pull_request:
-    paths-ignore:
-      - "CONTRIBUTING.md"
   release:
     types:
       - published
@@ -89,8 +87,7 @@ jobs:
             libunwind-dev
             zlib1g-dev &&
           tar xvf bloomberg-comdb2.tar.gz &&
-          (cd bloomberg-comdb2/build && sudo make install) &&
-          rm -rf bloomberg-comdb2.tar.gz bloomberg-comdb2/
+          (cd bloomberg-comdb2/build && sudo make install)
         '
       - uses: actions/checkout@v4
       - name: 'Set up Python 3.7'
@@ -100,7 +97,7 @@ jobs:
       - name: Build sdist
         run: '
           sudo apt-get install -qy pkg-config &&
-          PKG_CONFIG_PATH=/opt/bb/lib/pkgconfig:/usr/lib/x86_64-linux-gnu/pkgconfig
+          PKG_CONFIG_PATH=/opt/bb/lib/pkgconfig:/usr/lib/x86_64-linux-gnu/pkgconfig:$PKG_CONFIG_PATH
           pipx run build --sdist
         '
       - name: Upload sdist
@@ -145,7 +142,6 @@ jobs:
       - name: Start local comdb2 instance
         run: '
           sudo mkdir -p /opt/bb/share/schemas/$COMDB2_DBNAME &&
-          sudo mkdir -p /opt/bb/etc/cdb2/config &&
           echo "$COMDB2_DBNAME 1234 $(hostname -f)" > /opt/bb/etc/cdb2/config/comdb2db.cfg &&
           (/opt/bb/bin/pmux -n &) &&
           echo started pmux &&
@@ -190,7 +186,7 @@ jobs:
         run: '
           sudo apt-get install -qy pkg-config &&
           python -m pip install --upgrade pip &&
-          PKG_CONFIG_PATH=/opt/bb/lib/pkgconfig:/usr/lib/x86_64-linux-gnu/pkgconfig
+          PKG_CONFIG_PATH=/opt/bb/lib/pkgconfig:/usr/lib/x86_64-linux-gnu/pkgconfig:$PKG_CONFIG_PATH
           LDFLAGS="-Wl,-rpath,/opt/bb/lib"
           python -m pip install ./python-comdb2-sdist[tests]
         '