Add dependencies comparator

[marciniwanicki]

Resolves: #41

Describe your changes
Added new comparator to compare "Dependencies" build phases.

Usage:

xcdiff -g dependencies

Testing performed

• Compare the same project to itself

  • Run xcdiff -p1 Fixtures/ios_project_1/Project.xcodeproj -p2 Fixtures/ios_project_1/Project.xcodeproj -g dependencies
  • Verify no differences are flagged

• Compare two different projects

  • Run xcdiff -p1 Fixtures/ios_project_1/Project.xcodeproj -p2 Fixtures/ios_project_2/Project.xcodeproj -g dependencies
  • Verify dependencies differences are flagged correctly

[codecov]

Codecov Report

Merging #44 into master will increase coverage by 0.05%.
The diff coverage is 97.64%.

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
+ Coverage   96.12%   96.17%   +0.05%     
==========================================
  Files          43       44       +1     
  Lines        1598     1672      +74     
==========================================
+ Hits         1536     1608      +72     
- Misses         62       64       +2     

Impacted Files	Coverage Δ
...XCDiffCore/Comparator/DependenciesComparator.swift	97.14% <97.14%> (ø)
...Core/Comparator/LinkedDependenciesComparator.swift	92.00% <100.00%> (ø)
Sources/XCDiffCore/ComparatorType.swift	100.00% <100.00%> (ø)
Sources/XCDiffCore/Library/TargetsHelper.swift	93.54% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa9528d...3bc8d9a. Read the comment docs.

[kwridan]

Nice work 👍

We need to revisit how we extract the dependency names to make it cover more cases :)

[kwridan]

This will sadly crash in the event a project has a swift package dependency ... in that scenario there is no name, nor target! in fact looking at PBXTargetDependency there's even another type targetProxy!

The others are a bit easier:

   private func resolveDependencyDescription(from dependency: PBXTargetDependency) -> String? {
        let nameCandidates = [
            dependency.name,
            dependency.target?.name,
            dependency.product?.productName
        ]

        return nameCandidates.compactMap { $0 }.first
    }

For the target proxy we may have to construct some form or description based on the reference and maybe annotate it's a remote target or something along those lines.

[kwridan]

@marciniwanicki mind a rebase on master?

[kwridan]

Nice work @marciniwanicki 👍

Tested it out with local swift packages

A minor suggestion for next time possibly a space around the = or maybe event have it as :

from:

❌ DEPENDENCIES > "Project" target

⚠️  Only in second (3):

  • (product_name=MyLibrary, context=none)
  • (target=MismatchingLibrary)
  • (target=NewFramework)

to:

❌ DEPENDENCIES > "Project" target

⚠️  Only in second (3):

  • (product_name: MyLibrary, context: none)
  • (target: MismatchingLibrary)
  • (target: NewFramework)

Happy to do it as a follow up myself if you think it looks nicer.