Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend dependencies comparator to include target dependencies #41

Closed
kwridan opened this issue Jan 14, 2020 · 0 comments · Fixed by #44
Closed

Extend dependencies comparator to include target dependencies #41

kwridan opened this issue Jan 14, 2020 · 0 comments · Fixed by #44
Labels
enhancement New feature or request

Comments

@kwridan
Copy link
Contributor

kwridan commented Jan 14, 2020

Is your feature request related to a problem? Please describe.
The current dependencies comparison highlights differences in linked frameworks however doesn't take into account the target dependencies ("Dependencies" build phase).

Screenshot 2020-01-14 at 10 14 20

Describe the solution you'd like
We can rename the existing "Dependencies" comparator to "Linked Dependencies" and create a new dependencies comparator that compares the "Dependencies" build phase.

Describe alternatives you've considered
An alternate would be to extend the existing dependencies comparator to include differences for the dependencies build phase along side the linked dependencies.
@kwridan kwridan added the enhancement New feature or request label Jan 14, 2020
@marciniwanicki marciniwanicki mentioned this issue Feb 2, 2020
Merged
marciniwanicki added a commit that referenced this issue Feb 2, 2020
@marciniwanicki
Rename dependencies comparator to linked_dependencies (#43)
f3fa795 
Part of: #41

**Describe your changes**
Renamed `DependenciesComparator` to `LinkedDependenciesComparator` as the comparator does not cover differences in Build Phases > Dependencies. 

**Testing performed**
- CI

Signed-off-by: Marcin Iwanicki <miwanicki1@bloomberg.net>
@marciniwanicki marciniwanicki mentioned this issue Feb 2, 2020
Merged
marciniwanicki added a commit that referenced this issue Jul 7, 2020
@marciniwanicki
Add dependencies comparator (#44)
9ee0650 
Resolves: #41

**Describe your changes**
Added new comparator to compare "Dependencies" build phases. 

Usage:
```sh
xcdiff -g dependencies
```

**Testing performed**

- Compare the same project to itself
  - Run `xcdiff -p1 Fixtures/ios_project_1/Project.xcodeproj -p2 Fixtures/ios_project_1/Project.xcodeproj -g dependencies `
  - Verify no differences are flagged

- Compare two different projects
  - Run `xcdiff -p1 Fixtures/ios_project_1/Project.xcodeproj -p2 Fixtures/ios_project_2/Project.xcodeproj -g dependencies `
  - Verify dependencies differences are flagged correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add dependencies comparator marciniwanicki/xcdiff
1 participant
@kwridan