JS-II P1 #233
Open
JS-II P1 #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 22, 2018 16:01
There was a problem hiding this comment.
Great
Your code is clean. You seem to have a great understanding of the fundementals of JavaScript.
Requested Improvements
I'd pay attention to the tests, your code looks awesome; however, it seems to be the little implementations to work on postincement vs. preincrement.
Questions
none
Rating: {1-3}
2
| this.age = options.age; | ||
| } | ||
| growOlder() { | ||
| return this.age++; |
There was a problem hiding this comment.
So, this should increment age before returning it.
| const nFactorial = (n) => { | ||
| // factorial example: !5 = 5 * 4 * 3 * 2 * 1 | ||
| // return the factorial of `n` | ||
| if (n === 0 || n === 1) { | ||
| return 1; |
There was a problem hiding this comment.
Should just return n instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.