fix: balance breakdown alignment #2364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicole-obrien
approved these changes
Apr 24, 2024
Tuditi
added a commit
that referenced
this pull request
Apr 25, 2024
* chore: increment desktop version to 1.0.2-alpha-1 * fix: change GHA node version from 20.x to 20.10.0 (#2340) * chore: increment shared package version * rename getDefaultPersistedNetwork to getDefaultStardustNetwork (#2352) * enhancement: check ipfs gateway health (#2342) * add default ipfs gateway to profiles + migrations * improve ipfsgateway table * remove and set primary gateway * add input popup * add validation function * rewrite ipfs gateway regarding * fix trailing slash * increase alpha version * update ipfsgateways * improve rewrite ipfs * download nfts after changing nodes * add IPFS health check * add https at start if missing * improve errormessage --------- Co-authored-by: Nicole O'Brien <nicole@bloomwallet.io> * try fix issue with testers * New Crowdin translations by Github Action (#2354) Co-authored-by: Crowdin Bot <support+bot@crowdin.com> * enhancement: use list of ipfs gateways as pool and fall backs (#2350) * get list of urls to download from * fix sorting * interrupt queue if url is reached * rename * unset prmary * cleanup code * fix: add tide to allow list for nfts add: more ipfs gateways Co-authored-by: Mark Nardi <nardimark7@gmail.com> * fix: errors in mint forms --------- Co-authored-by: Nicole O'Brien <nicole@bloomwallet.io> * enhancement: improve displayed nft warnings (#2356) * change invalid media type to error * improve error messages * add media type to nft alert * reverse content type * fix generic error messages on nfts * chore: increment desktop version to `1.0.2-alpha-3` * fix undefined error * fix setting of primary ipfs node (#2358) * chore: increment desktop version to `1.0.2` * fix: fix nfts (#2360) * fix re-download * Fix migration of persisted nft data Co-authored-by: Mark Nardi <nardimark7@gmail.com> --------- Co-authored-by: Nicole O'Brien <nicole@bloomwallet.io> * enhancement: add allow list to remote app configuration * fix: show scam nft warning on already downloaded nfts * fix: balance breakdown alignment (#2364) * fix: balance breakdown alignment * chore: improve type safety * chore: revert cols & rows * fix: conversion (#2367) --------- Co-authored-by: Tuditi <daviddetroch@pm.me> Co-authored-by: Jean Ribeiro <contact@jeanribeiro.dev> Co-authored-by: Mark Nardi <nardimark7@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <support+bot@crowdin.com> Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Solves the issue that the Balance Breakdown is misaligned:
...
Testing
Platforms
Instructions
...
Checklist