Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send native tokens l1 -> l2 without account balance #2367

Merged

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Apr 24, 2024

Summary

Fix send native tokens to accounts that don't have the base token on L2.

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@Tuditi Tuditi changed the base branch from develop to release/desktop-1.0.2 April 24, 2024 13:06
@Tuditi Tuditi marked this pull request as ready for review April 24, 2024 13:07
@jeeanribeiro jeeanribeiro merged commit a681883 into release/desktop-1.0.2 Apr 24, 2024
8 checks passed
@jeeanribeiro jeeanribeiro deleted the fix/send-l1-l2-without-account-balance branch April 24, 2024 14:04
Tuditi added a commit that referenced this pull request Apr 25, 2024
* chore: increment desktop version to 1.0.2-alpha-1

* fix: change GHA node version from 20.x to 20.10.0 (#2340)

* chore: increment shared package version

* rename getDefaultPersistedNetwork to getDefaultStardustNetwork (#2352)

* enhancement: check ipfs gateway health (#2342)

* add default ipfs gateway to profiles + migrations

* improve ipfsgateway table

* remove and set primary gateway

* add input popup

* add validation function

* rewrite ipfs gateway regarding

* fix trailing slash

* increase alpha version

* update ipfsgateways

* improve rewrite ipfs

* download nfts after changing nodes

* add IPFS health check

* add https at start if missing

* improve errormessage

---------

Co-authored-by: Nicole O'Brien <nicole@bloomwallet.io>

* try fix issue with testers

* New Crowdin translations by Github Action (#2354)

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>

* enhancement: use list of ipfs gateways as pool and fall backs (#2350)

* get list of urls to download from

* fix sorting

* interrupt queue if url is reached

* rename

* unset prmary

* cleanup code

* fix: add tide to allow list for nfts
add: more ipfs gateways

Co-authored-by: Mark Nardi <nardimark7@gmail.com>

* fix: errors in mint forms

---------

Co-authored-by: Nicole O'Brien <nicole@bloomwallet.io>

* enhancement: improve displayed nft warnings (#2356)

* change invalid media type to error

* improve error messages

* add media type to nft alert

* reverse content type

* fix generic error messages on nfts

* chore: increment desktop version to `1.0.2-alpha-3`

* fix undefined error

* fix setting of primary ipfs node (#2358)

* chore: increment desktop version to `1.0.2`

* fix: fix nfts (#2360)

* fix re-download

* Fix migration of persisted nft data

Co-authored-by: Mark Nardi <nardimark7@gmail.com>

---------

Co-authored-by: Nicole O'Brien <nicole@bloomwallet.io>

* enhancement: add allow list to remote app configuration

* fix: show scam nft warning on already downloaded nfts

* fix: balance breakdown alignment (#2364)

* fix: balance breakdown alignment

* chore: improve type safety

* chore: revert cols & rows

* fix: conversion (#2367)

---------

Co-authored-by: Tuditi <daviddetroch@pm.me>
Co-authored-by: Jean Ribeiro <contact@jeanribeiro.dev>
Co-authored-by: Mark Nardi <nardimark7@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants