Skip to content

Commit

Permalink
devtools: fix directory filter in forbidden token check
Browse files Browse the repository at this point in the history
[ upstream commit cb25876 ]

checkpatches.sh current complains on a patch [1] adding
ALLOW_EXPERIMENTAL_API in an example while this check is for app, lib
and drivers directories:

Warning in examples/ethtool/ethtool-app/Makefile:
Using experimental build flag for in-tree compilation

The regexp on entering files concerned by this filter is incorrect.
In the [1] case, the file full name is matched against "app" rather than
"+++ b/app".

1: https://patchwork.dpdk.org/patch/83902/

Fixes: 7413e7f ("devtools: alert on new calls to exit from libs")

Signed-off-by: David Marchand <david.marchand@redhat.com>
  • Loading branch information
david-marchand authored and bluca committed Nov 16, 2020
1 parent 298d935 commit 89831d1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion devtools/check-forbidden-tokens.awk
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ BEGIN {
}
for (i in deny_folders) {
re = "^\\+\\+\\+ b/" deny_folders[i];
if ($0 ~ deny_folders[i]) {
if ($0 ~ re) {
in_file = 1
last_file = $0
}
Expand Down

0 comments on commit 89831d1

Please sign in to comment.