Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Remove unused address definitions #1040

Merged
merged 2 commits into from
May 20, 2020

Conversation

tk26eng
Copy link
Contributor

@tk26eng tk26eng commented May 19, 2020

What this patch does to fix the issue.

This patch refactor redundant addresses.

Link to any relevant issues or pull requests.

Fix #1039

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label May 19, 2020
@tk26eng tk26eng requested a review from iizukak May 19, 2020 11:46
@tk26eng tk26eng self-assigned this May 19, 2020
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OA

@tk26eng tk26eng requested a review from primenumber May 19, 2020 14:27
Copy link
Contributor

@primenumber primenumber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RA

@tk26eng
Copy link
Contributor Author

tk26eng commented May 20, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented May 20, 2020

⏳Merge job is queued...

@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for C++ from tkng, tsawada, primenumber

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@bo-mergebot bo-mergebot bot merged commit af3cd51 into blue-oil:master May 20, 2020
@tk26eng tk26eng deleted the remove_unused_address branch May 21, 2020 01:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

global.tpl.h includes redundant address definitions
3 participants