Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Enable to save pretrain_vars.txt to GCS #1197

Merged
merged 4 commits into from
Sep 16, 2020
Merged

Enable to save pretrain_vars.txt to GCS #1197

merged 4 commits into from
Sep 16, 2020

Conversation

hadusam
Copy link
Contributor

@hadusam hadusam commented Sep 4, 2020 •
edited
Loading

What this patch does to fix the issue.

Related #1205

  • Enable to save pretrain_vars.txt to GCS
  • Refactor to use file_io module

Link to any relevant issues or pull requests.

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Sep 4, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada, tfujiwar, a-hanamoto

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python

  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

iizukak
iizukak approved these changes Sep 10, 2020
View reviewed changes
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
OA

@hadusam hadusam changed the title Enable to output GCS with pretrain Enable to save pretrain_vars.txt to GCS Sep 15, 2020
tfujiwar
tfujiwar approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@tfujiwar tfujiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RA

@hadusam
Copy link
Contributor Author

hadusam commented Sep 16, 2020

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Sep 16, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 5a32900 into blue-oil:master Sep 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iizukak iizukak iizukak approved these changes

@tfujiwar tfujiwar tfujiwar approved these changes

Assignees
No one assigned
Labels
CI: auto-run Run CI automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hadusam @iizukak @tfujiwar