Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Remove try-catch wrap in blueoil train command #650

Merged
merged 2 commits into from
Dec 10, 2019
Merged

Conversation

suttang
Copy link
Contributor

@suttang suttang commented Dec 5, 2019

Motivation and Context

When some error occurred during blueoil train, you can see an error message like below

()

Because there is no appropriate error handling in lmnet/executor/train.py.
So I remove the try-catch syntax to make the error content understandable even a little.

Description

  • remove try-catch wrapper in cmd/main.py train

How has this been tested?

run train manually, and test command

make test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature / Optimization (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@suttang suttang requested review from tkng and iizukak December 5, 2019 07:59
@suttang suttang self-assigned this Dec 5, 2019
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Dec 5, 2019
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ownership Approval.

@tkng
Copy link
Contributor

tkng commented Dec 10, 2019

  • Readability Approval

@tkng
Copy link
Contributor

tkng commented Dec 10, 2019

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Dec 10, 2019

⏳Merge job is queued...

@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@tkng
Copy link
Contributor

tkng commented Dec 10, 2019

Readability Approval

@tkng
Copy link
Contributor

tkng commented Dec 10, 2019

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Dec 10, 2019

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 6648afd into master Dec 10, 2019
@bo-mergebot bo-mergebot bot deleted the fix/cmd-train branch December 10, 2019 07:43
@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Dec 10, 2019

😱Something went wrong. Please contact administrators.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants