Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Allocate temporary buffer in initialization time #652

Merged
merged 2 commits into from
Dec 10, 2019

Conversation

primenumber
Copy link
Contributor

@primenumber primenumber commented Dec 10, 2019

Motivation and Context

Allocate temporary buffer in each execution of operator is waste of time and hard to determine how mach memory are used.
After merged this PR, I will change code to allocate memory in Network::init(), that makes easier to optimize memory use.

Description

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature / Optimization (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@primenumber primenumber self-assigned this Dec 10, 2019
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Dec 10, 2019
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for C++ from tkng, tsawada

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@tkng
Copy link
Contributor

tkng commented Dec 10, 2019

  • Ownership Approval
  • Readability Approval

@tkng
Copy link
Contributor

tkng commented Dec 10, 2019

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Dec 10, 2019

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 8b38840 into blue-oil:master Dec 10, 2019
@primenumber primenumber deleted the allocate-once branch December 13, 2019 10:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants