Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Remove unecessary if else and use dictionary instead #864

Merged
merged 4 commits into from
Feb 25, 2020

Conversation

Joeper214
Copy link
Contributor

@Joeper214 Joeper214 commented Feb 20, 2020

What this patch does to fix the issue.

Remove unnecessary if-else statement and use python dictionary instead on blueoil init

Link to any relevant issues or pull requests.

n/a

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Feb 20, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@Joeper214 Joeper214 self-assigned this Feb 20, 2020
Copy link
Contributor

@tfujiwar tfujiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It gets readable than before. Thank you!!
Readability Approval.

@tsawada
Copy link
Contributor

tsawada commented Feb 20, 2020

Please put me as a reviewer after ownership approval

@tsawada tsawada removed their request for review February 20, 2020 10:50
@Joeper214
Copy link
Contributor Author

@iizukak This Needs Ownership Review.

Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ownership Approval

@Joeper214 Joeper214 requested review from tsawada and tkng and removed request for tsawada and tkng February 25, 2020 03:35
@Joeper214 Joeper214 added the CI: test-dlk Run dlk test once label Feb 25, 2020
@blueoil-butler blueoil-butler bot removed the CI: test-dlk Run dlk test once label Feb 25, 2020
Copy link
Contributor

@tsawada tsawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability Approval

@Joeper214
Copy link
Contributor Author

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Feb 25, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit 860ce1b into blue-oil:master Feb 25, 2020
@Joeper214 Joeper214 deleted the refactoring branch February 25, 2020 23:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants