Improve performance #121
Merged
Improve performance #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure why the coverage decreases |
|
Ah because of the driftbif_datasets.py, I added it to be omited |
jneuff
reviewed
Dec 19, 2016
| >>> ds = velocity(tau=3.5) # Dissipative soliton with equilibrium velocity 1.5e-3 | ||
| >>> print ds.label # Discriminating before or beyond Drift-Bifurcation | ||
| 1 | ||
| >>> print ds.deterministic # Equilibrium velocity |
There was a problem hiding this comment.
I would be nice to be able to run these doctests on Python 3. Maybe it suffices to from __future__ import print_function in this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started comparing the runtime of individual feature calculator as in issue #74
turns out that "sample_entropy" and "approximate_entropy" take forever to calculate. I marked them with the attribute "high_comp_cost".
Further, now the constructor of the FeatureExtractionSettings object will not calculate those "high_comp_cost" features.