Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve relevance table function documentation #781

Merged
merged 3 commits into from
Dec 23, 2020
Merged

Improve relevance table function documentation #781

merged 3 commits into from
Dec 23, 2020

Conversation

joclement
Copy link
Contributor

Is the style and wording good like this?

Describe different, additional columns in relevance table for
multiclass case.
@codecov-io
Copy link

codecov-io commented Dec 21, 2020

Codecov Report

Merging #781 (b3f6d68) into main (9184b4b) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #781      +/-   ##
==========================================
+ Coverage   95.77%   95.88%   +0.11%     
==========================================
  Files          18       18              
  Lines        1774     1774              
  Branches      347      347              
==========================================
+ Hits         1699     1701       +2     
+ Misses         37       36       -1     
+ Partials       38       37       -1     
Impacted Files Coverage Δ
tsfresh/feature_selection/relevance.py 95.28% <ø> (ø)
tsfresh/feature_selection/significance_tests.py 94.28% <0.00%> (+2.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9184b4b...b3f6d68. Read the comment docs.

Copy link
Collaborator

@nils-braun nils-braun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a very small comment. Thank you very much!

tsfresh/feature_selection/relevance.py Outdated Show resolved Hide resolved
Co-authored-by: Nils Braun <nils-braun@users.noreply.github.com>
@nils-braun nils-braun merged commit c071fd8 into blue-yonder:main Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants