Support user-provided gmock/gtest #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building in a conda environment where gtest and gmock are installed is currently causing weird linking issues. Instead of failing, we should just use the one from the environment and don't build our own. Sadly CMake's built-in `FindGTest.cmake` doesn't support GMock so I've bundled the modified version from Apache Arrow.
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
=======================================
Coverage 98.68% 98.68%
=======================================
Files 145 145
Lines 3338 3338
=======================================
Hits 3294 3294
Misses 44 44Continue to review full report at Codecov.
|
|
Please add a Changelog entry, other than that, no objections :-) |
Done |
|
Thanks a lot, Uwe! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building in a conda environment where gtest and gmock are installed is
currently causing weird linking issues. Instead of failing, we should
just use the one from the environment and don't build our own.
Sadly CMake's built-in
FindGTest.cmakedoesn't support GMock so I'vebundled the modified version from Apache Arrow.