Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spec_to_generic! cfg optimism applies in call site #1399

Closed
DaniPopes opened this issue May 12, 2024 · 0 comments · Fixed by #1412
Closed

spec_to_generic! cfg optimism applies in call site #1399

DaniPopes opened this issue May 12, 2024 · 0 comments · Fixed by #1412
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@DaniPopes
Copy link
Collaborator

spec_to_generic! macro requires users to define an optimism feature if it's also enabled in revm.

revm/crates/primitives/src/specification.rs

Line 212 in a04c7cd

macro_rules! spec_to_generic {

The macro should be duplicated, one with cfg(feature), the other with cfg(not(feature))
@DaniPopes DaniPopes added bug Something isn't working good first issue Good for newcomers labels May 12, 2024
gakonst added a commit to paradigmxyz/reth that referenced this issue May 12, 2024
@gakonst
chore: vendor eip-3074
6768418 
temporary workaround to fix bluealloy/revm#1399

https://github.com/paradigmxyz/reth/actions/runs/9051454049/job/24867990141\?pr\=7818

this does not really matter as eip-3074 will be removed and we're only temporarily importing it via node builder
@DaniPopes DaniPopes mentioned this issue May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(primitives): specify the optimism cfg on spec_to_generic DaniPopes/revm
1 participant
@DaniPopes