Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Interpreter): is_revert should call is_revert #1007

Merged
merged 1 commit into from
Jan 23, 2024
Merged

fix(Interpreter): is_revert should call is_revert #1007

merged 1 commit into from
Jan 23, 2024

Conversation

rakita
Copy link
Member

@rakita rakita commented Jan 23, 2024

From comment here: https://github.com/bluealloy/revm/pull/1002/files#r1461978421

Introduced yesterday

Copy link
Contributor

Valgrind Results:

==3842== Cachegrind, a cache and branch-prediction profiler
==3842== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==3842== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==3842== Command: target/release/snailtracer
==3842== 
--3842-- warning: L3 cache found, using its data for the LL simulation.
Snailtracer Host+Interpreter benchmark (2.1s) ...            not enough samples
==3842== 
==3842== I   refs:      455,349,609
==3842== I1  misses:         16,874
==3842== LLi misses:          2,878
==3842== I1  miss rate:        0.00%
==3842== LLi miss rate:        0.00%
==3842== 
==3842== D   refs:      237,389,050  (160,565,358 rd   + 76,823,692 wr)
==3842== D1  misses:        349,270  (    208,974 rd   +    140,296 wr)
==3842== LLd misses:        137,557  (      4,052 rd   +    133,505 wr)
==3842== D1  miss rate:         0.1% (        0.1%     +        0.2%  )
==3842== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==3842== 
==3842== LL refs:           366,144  (    225,848 rd   +    140,296 wr)
==3842== LL misses:         140,435  (      6,930 rd   +    133,505 wr)
==3842== LL miss rate:          0.0% (        0.0%     +        0.2%  )

@rakita rakita merged commit 00138a5 into main Jan 23, 2024
25 checks passed
@rakita rakita deleted the is_revert branch January 23, 2024 13:35
@github-actions github-actions bot mentioned this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant