Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: substitute web3db to ethersdb #293

Merged
merged 11 commits into from Dec 15, 2022
Merged

feature: substitute web3db to ethersdb #293

merged 11 commits into from Dec 15, 2022

Conversation

0xDmtri
Copy link
Contributor

@0xDmtri 0xDmtri commented Dec 10, 2022

Add ethersdb feature that relies on ethers-rs instead of web3db that depends on non native web3.

TODO:

  1. Update version.
  2. Add to CHANGELOG.md.
  3. Code review.

gakonst
gakonst approved these changes Dec 12, 2022
View reviewed changes
crates/revm/Cargo.toml Outdated Show resolved Hide resolved
rakita
rakita reviewed Dec 12, 2022
View reviewed changes
Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Finally this is added :)

Just address the comment and will merge it.

@rakita
Copy link
Member

rakita commented Dec 15, 2022

The test fails as it enables web3db features and has compile_error!. Will fix it later.

@rakita rakita merged commit 222b8e9 into bluealloy:main Dec 15, 2022
@github-actions github-actions bot mentioned this pull request Jan 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakita rakita rakita left review comments

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@0xDmtri @rakita @gakonst