feat: separate initial checks #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakita
commented
May 9, 2023
Closed
This was referenced Feb 8, 2024
Merged
This was referenced Feb 16, 2024
Closed
Merged
This was referenced Feb 24, 2024
Merged
This was referenced Mar 8, 2024
Merged
This was referenced Mar 12, 2024
This was referenced Mar 22, 2024
Closed
Closed
Closed
Merged
This was referenced Apr 2, 2024
Merged
This was referenced Apr 16, 2024
This was referenced May 2, 2024
Closed
This was referenced May 13, 2024
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a lot of refactor of initial EVM call
Added a bench for the simple transfer of value transaction, it got slightly faster from 700ns to 500ns but that is like ~5-10min saved for 2trilion of eth transactions, so it does not have a big impact.
Most of changes are internal, only external change is that previously only touched accounts (touch means something is done on them) would be returned but now all account from the journal state is returned.