Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Settings app #316

Merged
merged 1 commit into from
Feb 19, 2022
Merged

Add Settings app #316

merged 1 commit into from
Feb 19, 2022

Conversation

yashash-pugalia
Copy link
Collaborator

The settings app has been added !!!

image image

#53 #100 #302 #303

Type of change

  • New feature (non-breaking change which adds functionality)

@win11bot
Copy link
Collaborator

⌛ Deploy Preview - Build in Progress
If you are part of our discord server then leave your discord name for a role.

@yashash-pugalia
Copy link
Collaborator Author

yashash-pugalia commented Feb 19, 2022

@blueedgetechno for now I set a max-width to settings app ig we can make it more responsive for smaller screens later.

its fine now afaik please review and merge

@win11bot
Copy link
Collaborator

✔️ Deploy Preview for win11blue ready!
😎 Browse the preview: https://316.pr.blueedge.me !
🔨 If you experience an SSL issue then wait 2 minutes and try again.
🔍 Inspect the deploy log: https://github.com/blueedgetechno/win11React/actions/runs/1867827935

@yashash-pugalia yashash-pugalia self-assigned this Feb 19, 2022
@andrewstech
Copy link
Collaborator

Hey @yashash1511 test-on-pr / test-tauri will fail till after this is merged due to me adding the keyfiles. But don't worry I have manually checked it and it works.

Copy link
Collaborator

@andrewstech andrewstech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ready to merge

@andrewstech andrewstech added enhancement New feature or request Mega-Pull-Request A huge pull request new-feature labels Feb 19, 2022
@Posandu
Copy link
Contributor

Posandu commented Feb 19, 2022

@yashash1511 ig this should changed to blue
image

@yashash-pugalia
Copy link
Collaborator Author

yashash-pugalia commented Feb 19, 2022

@Posandu I was thinking about adding features like user being able to set their own name. So we will switch to that (maybe this can be in OOBE @cupofcoffebruh )

#301

@yashash-pugalia yashash-pugalia requested review from blueedgetechno and removed request for blueedgetechno February 19, 2022 14:11
@yashash-pugalia
Copy link
Collaborator Author

yashash-pugalia commented Feb 19, 2022

@blueedgetechno it is ready to be merged

also I didn't remove container query polyfill as i think we have many uses for it. (its just 1.6kB)
for example in the calculator app we can have history pane automatically show after certain width just like real win11.

@blueedgetechno
Copy link
Owner

Merge it, 🎉

@andrewstech andrewstech merged commit 9b935c3 into blueedgetechno:master Feb 19, 2022
@andrewstech andrewstech linked an issue Feb 21, 2022 that may be closed by this pull request
yashash-pugalia pushed a commit that referenced this pull request Mar 23, 2022
@yashash-pugalia yashash-pugalia removed their assignment May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Mega-Pull-Request A huge pull request new-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

idea
5 participants