-
-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Settings app #53
Comments
Thanks Yash, I saw your project. Do you plan to replace the images of different settings page with their corresponding responsive html and css? |
And I scraped the icons from sys32 folders and some from programs exe files |
This comment has been minimized.
This comment has been minimized.
@blueedgetechno I have replaced the images with HTML & CSS. The only thing left are the icons which I am currently having trouble getting since I don't have access to a Win11 device. |
@yashash1511 You can go to this repo's /public/img/icon to find them |
@blueedgetechno I was able to get icons from microsoft's Fluent UI System Icons gh-repo but thanks anyway. P.S. Do you plan on including the settings app in your project? |
@yashash1511 Yes, I will for sure take that into consideration but I have to rework it from scratch in react, If only you could help uwu |
@blueedgetechno I would have been happy to help, but I don't know if I could as I don't have any knowledge of react, maybe you could put it in an iframe. |
@blueedgetechno i have reworked it in react github.com/yashash1511/win11-settings-react |
We could add it in the same way as Minecraft. |
Minecraft from what I know was added as an iframe only and I already suggested that before |
THIS ISSUE HAS BEEN MARKED AS A NEW FEATURE |
@yashash1511 Can you try merging it in the windows11 code. Just look in the "containers/applications/apps", there are plenty of available apps, follow the basic template and merge it with the windows 11 application. And make sure to make a pull request when you are done. |
@blueedgetechno can i just iframe it as integrating it in the win11 code seems a bit tedious |
We should avoid iframe as it invites network lag and also as we will implement the functions of setting app, it wont be possible due to iframe. |
oohhk, i get it now thanks for explaning |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
This issue was closed because it has been stalled for 5 days with no activity. |
i am trying to replicate the windows 11 settings app https://github.com/moreorless-ml/win11-settings , maybe you could include it, btw amazing work. 馃憤
P.S. From where did you get the icons.
The text was updated successfully, but these errors were encountered: