Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Settings app #53

Closed
ghost opened this issue Aug 6, 2021 · 18 comments
Closed

Add Settings app #53

ghost opened this issue Aug 6, 2021 · 18 comments
Labels

Comments

@ghost
Copy link

ghost commented Aug 6, 2021

i am trying to replicate the windows 11 settings app https://github.com/moreorless-ml/win11-settings , maybe you could include it, btw amazing work. 馃憤

P.S. From where did you get the icons.

@blueedgetechno
Copy link
Owner

blueedgetechno commented Aug 6, 2021

Thanks Yash, I saw your project. Do you plan to replace the images of different settings page with their corresponding responsive html and css?

@blueedgetechno
Copy link
Owner

And I scraped the icons from sys32 folders and some from programs exe files

@ghost

This comment has been minimized.

@ghost
Copy link
Author

ghost commented Aug 6, 2021

@blueedgetechno I have replaced the images with HTML & CSS. The only thing left are the icons which I am currently having trouble getting since I don't have access to a Win11 device.

@blueedgetechno
Copy link
Owner

@yashash1511 You can go to this repo's /public/img/icon to find them

@ghost
Copy link
Author

ghost commented Aug 8, 2021

@blueedgetechno I was able to get icons from microsoft's Fluent UI System Icons gh-repo but thanks anyway.

P.S. Do you plan on including the settings app in your project?
It could feature things like going to Settings>Personalization and then users could change themes.

@blueedgetechno
Copy link
Owner

@yashash1511 Yes, I will for sure take that into consideration but I have to rework it from scratch in react, If only you could help uwu

@ghost
Copy link
Author

ghost commented Aug 8, 2021

@blueedgetechno I would have been happy to help, but I don't know if I could as I don't have any knowledge of react, maybe you could put it in an iframe.

@blueedgetechno blueedgetechno added the enhancement New feature or request label Sep 5, 2021
@yashash-pugalia
Copy link
Collaborator

@yashash1511 Yes, I will for sure take that into consideration but I have to rework it from scratch in react, If only you could help uwu

@blueedgetechno i have reworked it in react github.com/yashash1511/win11-settings-react

@Ccode-lang
Copy link
Contributor

We could add it in the same way as Minecraft.

@yashash-pugalia
Copy link
Collaborator

yashash-pugalia commented Sep 29, 2021

We could add it in the same way as Minecraft.

Minecraft from what I know was added as an iframe only and I already suggested that before

@win11bot
Copy link
Collaborator

THIS ISSUE HAS BEEN MARKED AS A NEW FEATURE

@blueedgetechno
Copy link
Owner

@yashash1511 Can you try merging it in the windows11 code. Just look in the "containers/applications/apps", there are plenty of available apps, follow the basic template and merge it with the windows 11 application.

And make sure to make a pull request when you are done.

@yashash-pugalia
Copy link
Collaborator

image

@yashash1511 Can you try merging it in the windows11 code.

@blueedgetechno can i just iframe it as integrating it in the win11 code seems a bit tedious

@blueedgetechno
Copy link
Owner

We should avoid iframe as it invites network lag and also as we will implement the functions of setting app, it wont be possible due to iframe.

@yashash-pugalia
Copy link
Collaborator

yashash-pugalia commented Oct 1, 2021

oohhk, i get it now thanks for explaning

@win11bot
Copy link
Collaborator

win11bot commented Nov 1, 2021

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@win11bot win11bot added the Stale label Nov 1, 2021
@win11bot
Copy link
Collaborator

win11bot commented Nov 7, 2021

This issue was closed because it has been stalled for 5 days with no activity.

@win11bot win11bot closed this as completed Nov 7, 2021
@yashash-pugalia yashash-pugalia mentioned this issue Feb 17, 2022
1 task
Repository owner deleted a comment from win11bot Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants