add mobile detect and create pdf mobile component #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dxinteractive
suggested changes
Jun 13, 2018
| } | ||
| } | ||
|
|
||
| export default ElementQueryHock()(PdfStepMobile); |
There was a problem hiding this comment.
Looks like you're not using ElementQueryHock() anymore, can you please remove it?
| return <Box spruceName="PdfStep"> | ||
| <Box className="PdfStep_document"> | ||
| <Text element="p" modifier="block center"> | ||
| The module has detected that you are using a mobile device. <br/>You can view the PDF document by clicking on the button below. <br/> Once you have read the document, please navigate back to this page to continue the module. |
There was a problem hiding this comment.
Instead of " The module has detected...", can we say "We've detected..."?
| //@flow | ||
| import React from 'react'; | ||
| import type {Element} from 'react'; | ||
| import ElementQueryHock from 'stampy/lib/hock/ElementQueryHock'; |
There was a problem hiding this comment.
If you're not using ElemenetQueryHock could you please remove it?
JordanMarquez
changed the title
dxinteractive
approved these changes
Jun 13, 2018
JordanMarquez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.