Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

imagemagick_create_scaled_image #3103

Closed
spitzbubchen opened this issue Apr 21, 2014 · 1 comment
Closed

imagemagick_create_scaled_image #3103

spitzbubchen opened this issue Apr 21, 2014 · 1 comment

Comments

@spitzbubchen
Copy link

Two comments:

  1. When uploading an image, the function "imagemagick_create_scaled_image" overwrites the original image data file with new image data as outputted by 'exec convert'. This is not appropriate in cases where it is essential that the original image file must remain untouched for later image processing purposes. Basically it seems that get_scaled_image_file_paths uses the same path and file name as the original.
  2. Often imagemagick can read a certain image format, but cannot output the same format (ex DCM). However, imagemagick can convert it to a more standard format (ex. "convert a.dcm a.png"). It would be nice if there was an option to set all thumbnail and preview processing to one image format, such as PNG. This would solve issue Error ! #1 in that thumbnail and preview processing would be separated from the original image data, and in addition, it would expand the capability of jQuery-File-Upload to process more image formats. In general, there is no need to save thumbnails and preview images in the same format as the original image data as such images are just used for a quick qualitative inspection.
@blueimp
Copy link
Owner

blueimp commented Apr 23, 2014

  1. You can disable the auto_orient feature for the original image version to disable this behavior:
    https://github.com/blueimp/jQuery-File-Upload/blob/master/server/php/UploadHandler.php#L125
  2. I agree it would be a nice capability.
    If I get a quality pull request implementing this feature, I'll consider including it. I probably won't have the time to implement this myself anytime in the near future though.
    As the focus of this project is on enhancing the client-side file upload experience, any server-side additions have a low priority for me.

@blueimp blueimp closed this as completed Apr 23, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants