AnimatorChangeHandler w/ removesFromViewOnPush=false breaks when popping multiple transactions

[tomblenz]

Reproduction:

1. Start with RootController, push Controller1 and Controller2 using new HorizontalChangeHandler(false) as push/pop change handlers (or any other AnimatorChangeHandler)
2. Call getRouter().popToRoot() on Controller2

Expected: Controller1 and Controller2 are popped and their views are removed.

Actual: Controller1 and Controller2 are popped but only Controller2's views are removed. Controller1's views remain on screen.

Attachments

1. Screenshot showing MainActivity's router backstack after popToRoot, verifying that only RootController exists.
   

2. Screenshot showing the inspected layout after popToRoot, showing that RootController and Controller1's views are inflated, while Controller2's views were removed from the container.
   

3. Reproduction project
   ChangeHandlerConductorBug.zip

[sockeqwe]

This is a world class bug report! Well done! I wish more people would take the time to file such bug reports! 👍

[tomblenz]

You took the time to make this framework, I think it's the least we can do :)

[sockeqwe]

No it wasn't me, all credits to @EricKuck

[EricKuck]

Thanks for the great bug report. This should now be fixed in the latest snapshot.