-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ManagerDeviceList: Hide devices with no name #1258
Conversation
I'm not really sure if this is a good idea. The hypothesis is that once you set devices into pairing mode, they do provide a name? I'll test some devices to see if that holds. If that's correct, don't we have to add devices on property changes (i.e. when a name appears) as well then? Currently we only add them when they show up initially. Regarding the terms: unnamed, unknown, anonymous? A no name device is typically Chinese with no name on it. 😉 |
Not really but if they do they will show up when searching. Android literally hides these when searching and you have to go into developer options to change it. I think windows does the same as I never see them there as well. I don't own one of these devices but have plenty showing up from my neighbours. If you do have one It would be nice if you can test this 😄 .
I can move this into a filter function on the liststore but this is a pita to do.
Unnamed sound much better. I'll reverse the logic and make the menu entry "Show unnamed". Maybe add a little tooltip with explanation. |
I tried to test the hypothesis a little bit but did not find good examples. I guess it's valid, though. We can try. |
After playing with Bluetooth a little bit in the last time I'm rather confident that this is a good idea now. 😄 |
Cool. I'll fix them conflicts later this week. |
a9c3fd9
to
aa2997a
Compare
Definitely deserves a changelog entry. |
Doh!! 😫. I'll do it tonight.
|
There are a lot of them and it make finding the device you are looking for harder.
Rebased and updated changelog. |
I don't like the menu entry name but at 1 in the morning I am out of ideas 😪. If you have a suggestion feel free to comment.