Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ManagerDeviceList: Hide devices with no name #1258

Merged
merged 3 commits into from
Dec 2, 2020

Conversation

infirit
Copy link
Contributor

@infirit infirit commented May 16, 2020

I don't like the menu entry name but at 1 in the morning I am out of ideas 😪. If you have a suggestion feel free to comment.

@cschramm
Copy link
Member

I'm not really sure if this is a good idea. The hypothesis is that once you set devices into pairing mode, they do provide a name? I'll test some devices to see if that holds.

If that's correct, don't we have to add devices on property changes (i.e. when a name appears) as well then? Currently we only add them when they show up initially.

Regarding the terms: unnamed, unknown, anonymous? A no name device is typically Chinese with no name on it. 😉

@infirit
Copy link
Contributor Author

infirit commented May 17, 2020

The hypothesis is that once you set devices into pairing mode, they do provide a name?

Not really but if they do they will show up when searching. Android literally hides these when searching and you have to go into developer options to change it. I think windows does the same as I never see them there as well. I don't own one of these devices but have plenty showing up from my neighbours. If you do have one It would be nice if you can test this 😄 .

If that's correct, don't we have to add devices on property changes (i.e. when a name appears) as well then? Currently we only add them when they show up initially.

I can move this into a filter function on the liststore but this is a pita to do.

Regarding the terms: unnamed, unknown, anonymous?

Unnamed sound much better. I'll reverse the logic and make the menu entry "Show unnamed". Maybe add a little tooltip with explanation.

@cschramm
Copy link
Member

cschramm commented Sep 6, 2020

I tried to test the hypothesis a little bit but did not find good examples. I guess it's valid, though. We can try.

@cschramm
Copy link
Member

After playing with Bluetooth a little bit in the last time I'm rather confident that this is a good idea now. 😄

@infirit infirit marked this pull request as ready for review November 23, 2020 18:25
@infirit
Copy link
Contributor Author

infirit commented Nov 23, 2020

Cool. I'll fix them conflicts later this week.

@infirit infirit force-pushed the hidenoname branch 2 times, most recently from a9c3fd9 to aa2997a Compare December 1, 2020 21:07
@infirit infirit requested a review from cschramm December 1, 2020 21:09
cschramm
cschramm previously approved these changes Dec 2, 2020
@cschramm
Copy link
Member

cschramm commented Dec 2, 2020

Definitely deserves a changelog entry.

@infirit
Copy link
Contributor Author

infirit commented Dec 2, 2020 via email

There are a lot of them and it make finding the device you are looking
for harder.
@infirit
Copy link
Contributor Author

infirit commented Dec 2, 2020

Rebased and updated changelog.

@infirit infirit merged commit 212aa8f into blueman-project:master Dec 2, 2020
@cschramm cschramm linked an issue Dec 23, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide devices with no name
2 participants