Fixing issue for SDP avigilon when activating onvif backchannel #479

[cedricve]

This will skip the C: attribute when containing SM. This is added by Avigilon cameras, and make the current SDP formatter fail. Original issue: #479

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1130b56) 84.58% compared to head (3ee4e66) 84.61%.

❗ Current head 3ee4e66 differs from pull request most recent head 28d0c2d. Consider uploading reports for the commit 28d0c2d to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #501      +/-   ##
==========================================
+ Coverage   84.58%   84.61%   +0.03%     
==========================================
  Files         106      106              
  Lines       10989    10992       +3     
==========================================
+ Hits         9295     9301       +6     
+ Misses       1296     1294       -2     
+ Partials      398      397       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[aler9]

@cedricve this can be surely merged but first can you post the troublesome SDP in text format, so i can add it to automatic tests? thanks

[cedricve]

@aler9 yes I noticed that. Please find the relevant SDP here.

v=0
o=- 1705180917694 1705180917694 IN IP4 192.168.1.63
s=Live
t=0 0
m=audio 0 RTP/AVP 0
c=IN IP4 192.168.1.63
a=control:rtsp://192.168.1.63/defaultPrimary/micCfg0/trackID=9?mtu=1440&streamType=u
a=recvonly
m=audio 0 RTP/AVP 0 97
c=IN IP4 192.168.1.63
c=SM SM spk0_trackID2
a=control:rtsp://192.168.1.63/defaultPrimary/spk0/trackID=2?mtu=1440&streamType=u
a=sendonly
a=rtpmap:0 pcmu/8000
a=rtpmap:97 opus/48000/2
m=video 0 RTP/AVP 96
c=IN IP4 192.168.1.63
a=control:rtsp://192.168.1.63/defaultPr

[aler9]

merged, thanks

[cedricve]

thanks @aler9, will we make a new release?

[cedricve]

@aler9 after applying this fix, we have managed to have audio backchannel activated (setup) for Avigilon cameras, however after sending data over the backchannel no audio is streamed through the speaker. So this might not have completely fixed the issue, we expect Avigilon cameras do something very specific.