Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEBRTC v0.23.0. error: webrtcICEHostNAT1To1IPs doesn't work if webrtcICEServers is empty #1817

Closed
1 of 13 tasks
alpe12 opened this issue May 17, 2023 · 3 comments · Fixed by #1821
Closed
1 of 13 tasks
Labels
bug Something isn't working webrtc

Comments

@alpe12
Copy link

alpe12 commented May 17, 2023

Which version are you using?

v0.23.0

Which operating system are you using?

  • Linux amd64 standard
  • Linux amd64 Docker
  • Linux arm64 standard
  • Linux arm64 Docker
  • Linux arm7 standard
  • Linux arm7 Docker
  • Linux arm6 standard
  • Linux arm6 Docker
  • Windows amd64 standard
  • Windows amd64 Docker (WSL backend)
  • macOS amd64 standard
  • macOS amd64 Docker
  • Other (please describe)

Describe the issue

Ever since this update the WEBRTC stream stopped working.
I open http://192.168.1.250:8889/cam/ and in the console:

requesting ICE servers
error: TypeError: links is null

Looking at the "networks" tab it constantly tries to access /cam/whep which return code 200 but with empty response. If i open /cam/whep directly I get 404.

Describe how to replicate the issue

mediamtx.yml
docker-compose.yml

Did you attach the server logs?

here

Did you attach a network dump?

no

@alpe12
Copy link
Author

alpe12 commented May 17, 2023

Update:
If I add
webrtcICEServers: [stun:stun.l.google.com:19302]
it works. Before it worked with [] in it.
I used to use [] on it because without it the server public IP was leaked to the client when it was not necessary (local client).
Does the current implementation prevents it?
If no, please make it work with [] as before, using only webrtcICEHostNAT1To1IPs: [192.168.1.250]

@alpe12 alpe12 changed the title WEBRTC not working on v0.23.0. error: TypeError: links is null WEBRTC v0.23.0. error: webrtcICEHostNAT1To1IPs doesn't work if webrtcICEServers is empty May 17, 2023
@aler9 aler9 added bug Something isn't working webrtc labels May 18, 2023
aler9 added a commit that referenced this issue May 18, 2023
this fixes a regression introduced in v0.23.0.
aler9 added a commit that referenced this issue May 18, 2023
… (#1821)

this fixes a regression introduced in v0.23.0.
@aler9
Copy link
Member

aler9 commented May 18, 2023

Fixed in in v0.23.1

Copy link
Contributor

This issue is being locked automatically because it has been closed for more than 6 months.
Please open a new issue in case you encounter a similar problem.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working webrtc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants