Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc: fix exception in browser when webrtcICEServers is empty (#1817) #1821

Merged
merged 1 commit into from
May 18, 2023

Conversation

aler9
Copy link
Member

@aler9 aler9 commented May 18, 2023

this fixes a regression introduced in v0.23.0.

Fixes #1817

this fixes a regression introduced in v0.23.0.
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@586df28). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #1821   +/-   ##
=======================================
  Coverage        ?   61.42%           
=======================================
  Files           ?      107           
  Lines           ?    10979           
  Branches        ?        0           
=======================================
  Hits            ?     6744           
  Misses          ?     3739           
  Partials        ?      496           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aler9 aler9 merged commit 6b8c65f into main May 18, 2023
6 checks passed
@aler9 aler9 deleted the bug/webrtc-ice branch May 18, 2023 12:58
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WEBRTC v0.23.0. error: webrtcICEHostNAT1To1IPs doesn't work if webrtcICEServers is empty
2 participants