Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow server wide disabling of recording Cleaner #2670

Closed
svk23 opened this issue Nov 10, 2023 · 4 comments · Fixed by #2671
Closed

Allow server wide disabling of recording Cleaner #2670

svk23 opened this issue Nov 10, 2023 · 4 comments · Fixed by #2671
Labels
bug Something isn't working general

Comments

@svk23
Copy link

svk23 commented Nov 10, 2023

Describe the feature

We are trying out the native recording functionality but we don't need the automatic deletion of recorded files. We have multiple streams that are recorded, each containing many (a couple of million) files. We found that the Cleaner takes up a lot of CPU on startup and periodically afterwards. It also seems to use a bit of memory compared to a server that has the same number of streams, but only a few recording segments. It would be nice to be able to disable the Cleaner, for example, with a global setting (e.g. recordEnableDelete that defaults to true). The option to disable automatic deletion by setting the time span to 0s per stream doesn't seem to have the desired effect, since the Cleaner still runs and uses unnecessary resources.

@aler9
Copy link
Member

aler9 commented Nov 10, 2023

Hello, i took a look at the record cleaning feature, and i found out that when recordDeleteAfter was set to zero, there was an infinite loop, that caused the CPU spike. This is fixed by #2671

@svk23
Copy link
Author

svk23 commented Nov 10, 2023

Hello, i took a look at the record cleaning feature, and i found out that when recordDeleteAfter was set to zero, there was an infinite loop, that caused the CPU spike. This is fixed by #2671

Excellent, thank you very much. I just tried that fix (#2671) on the aforementioned server and I can confirm that this resolves our performance issues!

Copy link
Contributor

This issue is mentioned in release v1.3.0 🚀
Check out the entire changelog by clicking here

Copy link
Contributor

This issue is being locked automatically because it has been closed for more than 6 months.
Please open a new issue in case you encounter a similar problem.

@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working general
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants