Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc: return detailed errors in responses #2594

Merged
merged 1 commit into from
Oct 28, 2023
Merged

webrtc: return detailed errors in responses #2594

merged 1 commit into from
Oct 28, 2023

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Oct 28, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Merging #2594 (957df1a) into main (f11f39f) will increase coverage by 0.11%.
Report is 1 commits behind head on main.
The diff coverage is 30.00%.

@@            Coverage Diff             @@
##             main    #2594      +/-   ##
==========================================
+ Coverage   59.87%   59.98%   +0.11%     
==========================================
  Files         145      145              
  Lines       15525    15537      +12     
==========================================
+ Hits         9295     9320      +25     
+ Misses       5588     5574      -14     
- Partials      642      643       +1     
Files Coverage Δ
internal/core/webrtc_manager.go 64.03% <0.00%> (-0.30%) ⬇️
internal/core/webrtc_session.go 62.84% <14.28%> (-0.59%) ⬇️
internal/core/webrtc_http_server.go 69.45% <42.10%> (+10.30%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aler9 aler9 merged commit 64eb907 into main Oct 28, 2023
7 of 8 checks passed
@aler9 aler9 deleted the feature/webrtc-err branch October 28, 2023 12:08
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant