Avoid appending custom proceed class to btn-primary, refactored dialog JS #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I largely refactored this to make a very basic change - to make it so that setting
data-confirm-proceed-class
overridesbtn-primary
as opposed to appending after it, as this doesn't style the element correctly, for example, a button with classbtn-primary btn-danger
can end up primary styled, they're not for use in conjunction.Other than that, this should work exactly as it did before, just a hell of a lot easier to read (I hope!).
Also, saves re-querying for DOM elements you've already seen - lots and lots of selectors before - I expect this performs faster.