Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent the default action on the modal's buttons. #9

Merged
merged 1 commit into from
Apr 24, 2013
Merged

Prevent the default action on the modal's buttons. #9

merged 1 commit into from
Apr 24, 2013

Conversation

kramerc
Copy link
Contributor

@kramerc kramerc commented Apr 23, 2013

Adding event.preventDefault() prevents the browser from navigating to #, the href value assigned to the modal's buttons. It also instructs libraries like Turbolinks to ignore these button links.

rvanlieshout added a commit that referenced this pull request Apr 24, 2013
Prevent the default action on the modal's buttons.
@rvanlieshout rvanlieshout merged commit 72581ee into bluerail:master Apr 24, 2013
@rvanlieshout
Copy link
Member

Thanks for your active support on this gem, @kramerc!

@kramerc
Copy link
Contributor Author

kramerc commented Apr 25, 2013

Glad to help! Thanks for the gem itself. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants