Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve menu scroll #1386

Merged
merged 3 commits into from
Jan 25, 2023
Merged

Improve menu scroll #1386

merged 3 commits into from
Jan 25, 2023

Conversation

patrickelectric
Copy link
Member

@patrickelectric patrickelectric commented Jan 22, 2023 •
edited

Now:
image

Before:
image

Fix ##1297

@patrickelectric patrickelectric requested review from rafaellehmkuhl and ES-Alexander and removed request for rafaellehmkuhl January 22, 2023 13:59
@ES-Alexander
Copy link
Collaborator

This seems to still cut off some of the page names (e.g. Ping Sonar Devices), so doesn't quite fix #1297.

@patrickelectric
core: frontend: plugins: vuetify: Enable css variables for theme
535f1bb 
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@patrickelectric
core: frontend: App: Change style for main menu scroll
3f0614d 
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@patrickelectric
core: frontend: App: Decrease padding around itens on side bar
5af76be 
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@patrickelectric
Copy link
Member Author

@ES-Alexander check now

ES-Alexander
ES-Alexander approved these changes Jan 25, 2023
View reviewed changes
Copy link
Collaborator

@ES-Alexander ES-Alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me :-)

Not sure if it'll be weird to have one scrollbar that's different to the others, but it does at least seem to solve the problem.

@patrickelectric patrickelectric merged commit d334ad2 into bluerobotics:master Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ES-Alexander ES-Alexander ES-Alexander approved these changes

@rafaellehmkuhl rafaellehmkuhl Awaiting requested review from rafaellehmkuhl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@patrickelectric @ES-Alexander