Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: frontend: store: autopilot: Add getters for parameters #1396

Merged

Conversation

patrickelectric
Copy link
Member

A replace for #1395

As discussed on the dentist

Signed-off-by: Patrick José Pereira patrickelectric@gmail.com

@Williangalvani
Copy link
Member

I think you need to declare things slightly differently in order for these to work as vuex getters.
check https://championswimmer.in/vuex-module-decorators/pages/core/getters.html and cd4ba04

It returns a lambda that takes the parameters

@patrickelectric
Copy link
Member Author

@Williangalvani check now

Copy link
Member

@Williangalvani Williangalvani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have a "filter" option that returns a list. This is useful in cases such as "Get me all the SERVOXX_FUNCTION" parameters". I'm not sure if it should be the regex one in this pr or new one that returns multiple elements

core/frontend/src/store/autopilot.ts Outdated Show resolved Hide resolved
@patrickelectric
Copy link
Member Author

I think we should have a "filter" option that returns a list. This is useful in cases such as "Get me all the SERVOXX_FUNCTION" parameters". I'm not sure if it should be the regex one in this pr or new one that returns multiple elements

The regex on returns multiple objects

@patrickelectric
Copy link
Member Author

I think we should have a "filter" option that returns a list. This is useful in cases such as "Get me all the SERVOXX_FUNCTION" parameters". I'm not sure if it should be the regex one in this pr or new one that returns multiple elements

The regex on returns multiple objects

Ops, my fault, fixing it

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants