Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: build armv8 64bit images #1404

Merged
merged 1 commit into from
Apr 1, 2023

Conversation

Williangalvani
Copy link
Member

just creating a draft to check if CI finds some errors for us

@Williangalvani
Copy link
Member Author

it doesnt show a manually built version on version chooser for me, which probably means the architecture filter in there is workind.

@Williangalvani
Copy link
Member Author

the tag for this branch doesnt show here though: https://hub.docker.com/layers/williangalvani/blueos-core/v8-goes-brrrrrr/images/sha256-706ba408ecf8d24cfc12a9091713006eca1c9ea5284a5cec079a383965f28363?context=explore

I suspect the one that finishes last is overwriting the first one, in CI

@Williangalvani
Copy link
Member Author

@patrickelectric thoughts?

The issue here is that we cant do the --output line for two different images at the same time.

I think we could maybe do something like a .join() somewhere. or maybe we can use --output for two lines, but I couldn't find how to do it.

@Williangalvani
Copy link
Member Author

nevermind me, it seems to be possible, let me troubleshoot it a bit further

@patrickelectric
Copy link
Member

You can use a matrix and the name of the architecture in the artifact

@Williangalvani
Copy link
Member Author

architecture

using a matrix causes 2 independent pushes to docker hub, where the latest one overwrites the first one

@patrickelectric
Copy link
Member

architecture

using a matrix causes 2 independent pushes to docker hub, where the latest one overwrites the first one

ouch, we can build both together and each individually for the artifacts, it should use the cache from both builds and just create it for us.

@Williangalvani
Copy link
Member Author

architecture

using a matrix causes 2 independent pushes to docker hub, where the latest one overwrites the first one

ouch, we can build both together and each individually for the artifacts, it should use the cache from both builds and just create it for us.

That is what the current change does. apparently we could use the "tar" output, but that doesn't seem to be "docker image specification compliant"

@Williangalvani Williangalvani marked this pull request as ready for review January 31, 2023 13:48
@patrickelectric patrickelectric force-pushed the v8-goes-brrrrrr branch 3 times, most recently from 5188488 to 23d2295 Compare March 31, 2023 15:04
Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some attempts to parallelize it but not ended well, I did updates and now appears to be fine.

@patrickelectric
Copy link
Member

Be free to merge.

@Williangalvani Williangalvani merged commit a774bc8 into bluerobotics:master Apr 1, 2023
@Williangalvani Williangalvani deleted the v8-goes-brrrrrr branch April 1, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants