Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve BlueOS logo #1409

Merged
merged 2 commits into from
Jan 28, 2023
Merged

Conversation

patrickelectric
Copy link
Member

  • Use new full logo

image

image

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Copy link
Collaborator

@ES-Alexander ES-Alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me :-)

My only note would be that companies re-skinning BlueOS will likely want to replace that main logo location with their own, in which case I'm not sure what the best location is for having a BlueOS logo (assuming we care about making it clear that the software running is based on BlueOS).

@patrickelectric
Copy link
Member Author

Looks fine to me :-)

My only note would be that companies re-skinning BlueOS will likely want to replace that main logo location with their own, in which case I'm not sure what the best location is for having a BlueOS logo (assuming we care about making it clear that the software running is based on BlueOS).

We are still discussing it and how to accomplish custom skins in a better way without building BlueOS.
Extensions or zip folders may be a solution.

@patrickelectric patrickelectric merged commit 6265a41 into bluerobotics:master Jan 28, 2023
@ES-Alexander
Copy link
Collaborator

We are still discussing it and how to accomplish custom skins in a better way without building BlueOS.
Extensions or zip folders may be a solution.

Yes, I'm expecting having a "theme" type of extension will be the most easily shareable. Longer term it would be good to have a theme editor built into BlueOS, so people can customise the theme from within BlueOS and then save and choose to share their theme automatically.

Regardless, that's unrelated to whether or not people will want to change the main logo, and doesn't necessarily help us determine where the best place is for a secondary BlueOS logo (assuming we want one) in the case of someone applying a custom theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants