Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create "userdata" folder for allowing customizations #1419

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

Williangalvani
Copy link
Member

Currently works with custom css files located in the host's /home/pi/userdata/user_style.css`
image

The screenshot uses these updated variables:

:root {
    --v-primary-base: #dd8603 !important;
    --v-info-base: #dd8603 !important;
    }

The full list (courtesy of somewhere in chrome's dev tools) is here: (upload when chrome is happier)

I intend to use the same or a similar mechanism to allow overriding images/models.

@Williangalvani
Copy link
Member Author

from meeting:
try loading a "model-override.glb", if it is not available, fallback to frame-specific

change to theme-style.css

@Williangalvani
Copy link
Member Author

add support for default firmware, default parameters.

Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@Williangalvani
Copy link
Member Author

nice!

thanks, I'm pushing some other stuff for the vehicle setup in here, but i'll probably remove it to add it in another pr later on. I'm just making sure everything works the way I expect first

@ES-Alexander
Copy link
Collaborator

change to theme-style.css

Is this still planned in this PR?

Comment on lines 193 to 196
# do we want these next two lines?
expires -1;
add_header Cache-Control no-store;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to disable cache, makes development easier... And I don't think it would impact that much on loading performance.

@Williangalvani Williangalvani changed the title [proposal] create "userdata" folder for allowing customizations create "userdata" folder for allowing customizations Feb 6, 2023
@Williangalvani
Copy link
Member Author

change to theme-style.css

Is this still planned in this PR?

updated

@Williangalvani
Copy link
Member Author

ping @patrickelectric

@ES-Alexander ES-Alexander added docs-complete Change documentation has been completed accessibility and removed docs-needed Change needs to be documented labels Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility docs-complete Change documentation has been completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants