core: frontend: menus: Organize menu to new logic

[patrickelectric]

Two categories: settings and tools

Based on SMS feedback

Also align side menu icons

Signed-off-by: Patrick José Pereira patrickelectric@gmail.com

[ES-Alexander]

A few page renaming suggestions.

Also, from your screenshot I've just seen that the pirate icons are apparently increasing the indentation for those page names, which is a bit weird. Not sure if that's easily fixed here or if it should be raised as an issue and fixed later.

[ES-Alexander]

Mostly looks good :-)

I didn't look at the descriptions earlier, so there are some minor suggestions for them here.

[joaoantoniocardoso]

Can we use this opportunity to align the labels?

... actually, the current master is correctly aligned. Also the font differs... Is your photo an actual screenshot? Is this your browser font only?

[patrickelectric]

[joaoantoniocardoso]

see my edit

[patrickelectric]

It appears to be a problem when you enable pirate mode, the pirate icons move the item title.

[patrickelectric]

@joaoantoniocardoso check now

[joaoantoniocardoso]

This part seems okay, but the menu name is slightly off compared to the category labels

1. non pirate
   
2. pirate
   
3. back to non pirate
   

[ES-Alexander]

Also the font differs... Is your photo an actual screenshot? Is this your browser font only?

Yes, that's an actual screenshot from my system. I was using Orion, but I seemingly have the same font on Chrome. I have not seen the font from your screenshot before, although I do have at least a vague recollection of my system giving "failed to fetch font" warnings previously in the console (or something like that), but I do not have such warnings at the moment.

the menu name is slightly off compared to the category labels

@joaoantoniocardoso I think it's that Dashboard is a page, which seemingly has a smaller left pad or margin or something than the dropdown sections. You'll note that the icon is also a bit further to the left for Dashboard than Tools, so the adjustment to fix it should be to the icon (or the whole row), which should fix the text automatically.

I was talking to Rusty this morning and he mentioned he'd prefer if they were aligned, so would be good if that can be fixed before we merge :-)

[patrickelectric]

@joaoantoniocardoso check the latest version